cmd/initContainer: Simplify code by removing a function parameter#1356
Merged
debarshiray merged 2 commits intocontainers:mainfrom Aug 22, 2023
Conversation
On new builds of GNOME OS [1], the host's / is mounted with 'nodev,...' and those flags are also inherited by /etc because it's not a separate mount point. This leads to the same problem with /etc/machine-id that was seen before with /var/lib/flatpak, /var/lib/systemd/coredump and /var/log/journal [2]. Therefore, use the same approach [2] to handle /etc/machine-id. [1] https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/718 [2] Commit 1cc9e07 containers@1cc9e07b7c36fe9f containers#1340 containers#911 containers#1354 Signed-off-by: Jordan Petridis <jordan@centricular.com>
Until now, configureUsers() was pushing the burden of deciding whether to add a new user or modify an existing one on the callers, even though it can trivially decide itself. Involving the caller loosens the encapsulation of the user configuration logic by spreading it across configureUsers() and it's caller, and adds an extra function parameter that needs to be carefully set and is vulnerable to programmer errors. Fallout from 9ea6fe5 containers#1356
debarshiray
force-pushed
the
wip/rishi/cmd-initContainer-configureUsers-remove-parameter
branch
from
3bb24d4 to
6bd7c87
Compare
|
Build failed. ❌ unit-test RETRY_LIMIT in 33s |
Member
Author
|
The tests run on Fedora Rawhide nodes are failing because of the same reasons as in #1344 and #1331 , and the root cause appears to be So, I am going to temporarily ignore these test failures on Fedora Rawhide. |
debarshiray
deleted the
wip/rishi/cmd-initContainer-configureUsers-remove-parameter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now,
configureUsers()was pushing the burden of deciding whetherto add a new user or modify an existing one on the callers, even though
it can trivially decide itself. Involving the caller loosens the
encapsulation of the user configuration logic by spreading it across
configureUsers()and it's caller, and adds an extra function parameterthat needs to be carefully set and is vulnerable to programmer errors.
Fallout from 9ea6fe5