Add KONSOLE_VERSION to the list of preserved env vars#1453
Add KONSOLE_VERSION to the list of preserved env vars#1453debarshiray merged 1 commit intocontainers:mainfrom notfirefox:fix-nvim-undercurl
Conversation
|
Build succeeded. ✔️ unit-test SUCCESS in 4m 37s |
debarshiray
left a comment
debarshiray
left a comment
There was a problem hiding this comment.
Thanks for figuring this out, @notfirefox ! Could you please correct your Git authorship information with your full name and a real email address, unless you are worried about privacy?
I'd prefer to keep the authorship information as it is because of privacy concerns. |
|
Build succeeded. ✔️ unit-test SUCCESS in 4m 45s |
I see. A few things: The I could have made an exception for a one line change, like adding an environment variable, because it would be legally insignificant. However, that's no longer the case with this pull request after the addition of the tests. :) We need a real full name and email address for tracking copyright holders in case a licensing issue crops up. Note how projects as diverse as GCC, GnuPG, Linux and Podman don't allow anonymous or pseudonymous contributions. |
|
Build succeeded. ✔️ unit-test SUCCESS in 4m 36s |
|
@debarshiray DCO related issues should be resolved now. |
debarshiray
left a comment
debarshiray
left a comment
There was a problem hiding this comment.
Thanks for updating the pull request, @notfirefox ! Let me rebase it against main.
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 33s |
|
Build succeeded. ✔️ unit-test SUCCESS in 4m 47s |
Konsole injects its version into the process running inside it through
the KONSOLE_VERSION environment variable [1]. This is used by programs
like Neovim to detect the terminal features supported by Konsole [2].
This is just like VTE and its VTE_VERSION environment variable.
The KONSOLE_VERSION environment variable is not meant to be set by the
shell's start-up scripts, but directly by Konsole, and hence needs to be
preserved across the host operating system and Toolbx container.
[1] Konsole commit b0d3d83eca4f523a
https://invent.kde.org/utilities/konsole/-/commit/b0d3d83eca4f523a
https://phabricator.kde.org/D12621
https://bugs.kde.org/show_bug.cgi?id=347323
[2] Neovim commit c16529afa5c8eb03
neovim/neovim@c16529afa5c8eb03
neovim/neovim#8300
#1449
Signed-off-by: Dominique Polek <dominique.polek@mailbox.org>
|
Build succeeded. ✔️ unit-test SUCCESS in 4m 39s |
|
Thanks for working on this, @notfirefox ; and for reconsidering the privacy issues! Much appreciated. |
2 participants
As discussed here.
KONSOLE_VERSIONto the list of preserved environment variablesCloses #1449