Skip to content

[WIP] .github/workflows: Try to enable all tests on Ubuntu 22.04 and 24.04#1505

Closed
debarshiray wants to merge 6 commits intocontainers:mainfrom
debarshiray:wip/rishi/run-tests-on-ubuntu-24.04-SHELL
Closed

[WIP] .github/workflows: Try to enable all tests on Ubuntu 22.04 and 24.04#1505
debarshiray wants to merge 6 commits intocontainers:mainfrom
debarshiray:wip/rishi/run-tests-on-ubuntu-24.04-SHELL

Conversation

@debarshiray
Copy link
Copy Markdown
Member

No description provided.

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 5, 2024
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-24.04-SHELL branch from b78413f to ffb7d8a Compare June 5, 2024 16:36
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 5, 2024
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-24.04-SHELL branch from ffb7d8a to be8627b Compare June 5, 2024 16:44
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/c4ca485c14d14a818d36abbcd0acb442

✔️ unit-test SUCCESS in 6m 34s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 16s
✔️ unit-test-restricted SUCCESS in 5m 54s
✔️ system-test-fedora-rawhide SUCCESS in 37m 10s
✔️ system-test-fedora-40 SUCCESS in 36m 19s
✔️ system-test-fedora-39 SUCCESS in 35m 29s
✔️ system-test-fedora-38 SUCCESS in 35m 48s

@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-24.04-SHELL branch from 11725b9 to a90daa7 Compare June 5, 2024 17:44
The extra debug logs from 'toolbox --verbose' are not needed for the
test case to work, and other tests don't gratuitously use --verbose
either.

Fallout from 55b5018

containers#1506
The test was earlier rewritten in commit b0beb68 with custom
code in the hope that it would make it more reliable.  The test has
proven to be reliable in recent times, and the cause for its past
unreliability is unclear.  Therefore, it will be better to remove the
custom code in favour of the standard Bats helpers for the sake of
consistency and readability.

Until Bats 1.10.0, 'run --keep-empty-lines' had a bug where it counted
the trailing newline on the last line as a separate line [1].  However,
Bats 1.10.0 is only available in Fedora >= 39 and is absent from Fedora
38.

[1] Bats commit 6648e2143bffb933
    bats-core/bats-core@6648e2143bffb933
    bats-core/bats-core#708

containers#1506
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-24.04-SHELL branch from a90daa7 to 8c3e57b Compare June 5, 2024 18:22
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/54c4eee4c86544b89d3358870eb27e00

✔️ unit-test SUCCESS in 7m 09s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 13s
✔️ unit-test-restricted SUCCESS in 5m 43s
✔️ system-test-fedora-rawhide SUCCESS in 36m 34s
✔️ system-test-fedora-40 SUCCESS in 37m 41s
✔️ system-test-fedora-39 SUCCESS in 38m 22s
✔️ system-test-fedora-38 SUCCESS in 38m 27s

@debarshiray debarshiray changed the title [WIP] .github/workflows: Try to enable all tests on Ubuntu 24.04 [WIP] .github/workflows: Try to enable all tests on Ubuntu 22.04 and 24.04 Oct 10, 2024
@debarshiray debarshiray deleted the wip/rishi/run-tests-on-ubuntu-24.04-SHELL branch November 11, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant