Skip to content

build: Bump github.com/spf13/cobra to 1.6.1 #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debarshiray merged 7 commits into from
Apr 1, 2026
Merged

build: Bump github.com/spf13/cobra to 1.6.1 #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d62377a
test/system: Test 'completion' with two invalid and valid arguments
debarshiray Mar 31, 2026
f2db50a
build: Bump github.com/spf13/cobra to 1.4.0
debarshiray Mar 24, 2026
4b02bf5
build: Bump github.com/spf13/cobra to 1.5.0
debarshiray Mar 24, 2026
b11c6f6
cmd/completion, cmd/root: Simplify log level completion with Cobra 1.5.0
debarshiray Mar 26, 2026
8b855c6
build: Bump github.com/spf13/cobra to 1.6.0
debarshiray Mar 30, 2026
2e367d5
cmd/completion: Replace deprecated github.com/spf13/cobra API
debarshiray Mar 30, 2026
b37e053
build: Bump github.com/spf13/cobra to 1.6.1
debarshiray Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/cmd/completion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var completionCmd = &cobra.Command{
Hidden: true,
DisableFlagsInUseLine: true,
ValidArgs: []string{"bash", "fish", "zsh"},
Args: cobra.ExactValidArgs(1),
Args: cobra.MatchAll(cobra.ExactArgs(1), cobra.OnlyValidArgs),
RunE: completion,
}

Expand Down Expand Up @@ -194,7 +194,3 @@ func completionImageNamesFiltered(_ *cobra.Command, args []string, _ string) ([]

return imageNames, cobra.ShellCompDirectiveNoFileComp
}

func completionLogLevels(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
return []string{"trace", "debug", "info", "warn", "error", "fatal", "panic"}, cobra.ShellCompDirectiveNoFileComp
}
4 changes: 3 additions & 1 deletion src/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ func init() {

persistentFlags.CountVarP(&rootFlags.verbose, "verbose", "v", "Set log-level to 'debug'")

if err := rootCmd.RegisterFlagCompletionFunc("log-level", completionLogLevels); err != nil {
logLevels := []string{"trace", "debug", "info", "warn", "error", "fatal", "panic"}
completionFn := cobra.FixedCompletions(logLevels, cobra.ShellCompDirectiveNoFileComp)
if err := rootCmd.RegisterFlagCompletionFunc("log-level", completionFn); err != nil {
panicMsg := fmt.Sprintf("failed to register flag completion function: %v", err)
panic(panicMsg)
}
Expand Down
4 changes: 2 additions & 2 deletions src/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ require (
github.com/godbus/dbus/v5 v5.0.6
github.com/google/renameio/v2 v2.0.0
github.com/sirupsen/logrus v1.9.3
github.com/spf13/cobra v1.3.0
github.com/spf13/cobra v1.6.1
github.com/spf13/viper v1.20.1
github.com/stretchr/testify v1.10.0
golang.org/x/sys v0.29.0
Expand All @@ -28,7 +28,7 @@ require (
github.com/fatih/color v1.14.1 // indirect
github.com/go-viper/mapstructure/v2 v2.4.0 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/inconshreveable/mousetrap v1.0.0 // indirect
github.com/inconshreveable/mousetrap v1.0.1 // indirect
github.com/mattn/go-colorable v0.1.13 // indirect
github.com/mattn/go-isatty v0.0.17 // indirect
github.com/opencontainers/runtime-spec v1.2.1 // indirect
Expand Down
Loading
Loading