First attempt at a CentOS-7 toolbox container.

[kronenpj]

Signed-off-by: Paul Kronenwetter kronenpj@gmail.com

Usage once it's available:

toolbox create --image centos-toolbox:7 tboxname
toolbox enter tboxname
{Do cool toolbox stuff here.}

It's a bit bloated now because of the yum update but when CentOS releases the 7.7 container it should be better and the yum update could be removed. I needed to perform the update before re-adding the documentation would work with yum reinstall.

[mvala]

+1

[nanonyme]

Maybe update this based on de5e5df while waiting for further review

[debarshiray]

Yes, many of the comments in #298 for the Ubuntu image also apply to this.

[mvala]

Is it possible to test it soon?

[cgwalters]

I think in the end we should try to support the default pre-existing base images and not require a special "toolbox image". Basically, have all of the logic inside our binary and not a derived image. That said, there are some complications around this, like sudo and the documentation.

[debarshiray]

Thanks for working on this!

I wonder if we should attempt CentOS 8 first. For the simple reason that it's new, and hence a lot more flexible compared to CentOS 7. No strong opinion, though.

[debarshiray]

Yes, many of the comments in #298 for the Ubuntu image also apply to this.

[debarshiray]

I think in the end we should try to support the default pre-existing base images
and not require a special "toolbox image". Basically, have all of the logic inside
our binary and not a derived image. That said, there are some complications
around this, like sudo and the documentation.

Currently the Toolbox images don't really have any logic. They are just a means of altering the package set of the base images. We could do all the package management dance on the clients running /usr/bin/toolbox but then we lose some of the reproducibility that the images offer.

But yeah, the prospect of just being able to work with the base images is tempting.

[fhoxh]

👍

[mvala]

Any updates here?

[softwarefactory-project-zuul]

Build succeeded.

• shellcheck : SUCCESS in 1m 10s
• test-with-podman-stable-f30 : SUCCESS in 3m 21s
• test-with-podman-stable-f31 : SUCCESS in 3m 33s
• test-with-podman-rawhide : SUCCESS in 4m 42s

[carwyn]

Arguably there's a strong case for needing both RHEL/CentOS 7 and 8 (any currently supported version). Surely they are two related tasks rather than waiting on 8 blocking 7 if that's closer to being ready?

[debarshiray]

Closing.

See #275