Move remove functions to the podman package#519
Merged
martymichal merged 2 commits intocontainers:masterfrom Aug 14, 2020
Merged
Move remove functions to the podman package#519martymichal merged 2 commits intocontainers:masterfrom
martymichal merged 2 commits intocontainers:masterfrom
Conversation
martymichal
force-pushed
the
move-remove-functions
branch
from
3d15737 to
b9f80f9
Compare
|
Build failed.
|
martymichal
force-pushed
the
move-remove-functions
branch
2 times, most recently
from
ace0554 to
cfc342c
Compare
|
Build failed.
|
The 'removeContainer' function should go into 'pkg/podman' because it wraps around Podman's command. Because it no longer has access to the commands - 'toolbox rm' - parameters it has a new forceDelete parameter. containers#519
The 'removeImage' function should go into 'pkg/podman' because it wraps around Podman's command. Because it no longer has access to the commands - toolbox rmi - parameters it has a new forceDelete parameter. containers#519
martymichal
force-pushed
the
move-remove-functions
branch
from
cfc342c to
3d3c425
Compare
|
Build failed.
|
martymichal
added a commit
that referenced
this pull request
Aug 14, 2020
The 'removeContainer' function should go into 'pkg/podman' because it wraps around Podman's command. Because it no longer has access to the commands - 'toolbox rm' - parameters it has a new forceDelete parameter. #519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions for removing containers/images are wrappers around Podman's commands. They should be in the
podmanpackage.