images: Add fedora-toolbox image definition for Fedora 34#532
Merged
debarshiray merged 1 commit intocontainers:masterfrom Aug 21, 2020
Merged
images: Add fedora-toolbox image definition for Fedora 34#532debarshiray merged 1 commit intocontainers:masterfrom
debarshiray merged 1 commit intocontainers:masterfrom
Conversation
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Aug 20, 2020
martymichal
force-pushed
the
add-fedora-34-image
branch
from
44b4f2d to
4c2a96c
Compare
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Aug 20, 2020
martymichal
force-pushed
the
add-fedora-34-image
branch
from
4c2a96c to
d233ff3
Compare
|
Build failed.
|
debarshiray
reviewed
Aug 21, 2020
Member
debarshiray
left a comment
debarshiray
left a comment
There was a problem hiding this comment.
Thanks, looks perfect.
Although, the README.md should be a symbolic link to the canonical copy at the root of the tree. That we don't have to keep several copies updated.
debarshiray
force-pushed
the
add-fedora-34-image
branch
from
d233ff3 to
3fee36c
Compare
Member
|
Fixed, and merged. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.