images: Use a regular file, not a symbolic link, for README.md#723
Merged
debarshiray merged 1 commit intocontainers:masterfrom Mar 15, 2021
Merged
Conversation
A while ago, 'podman build' stopped supporting COPY with relative symbolic links [1]. Therefore, these image definitions can't be used without first temporarily removing the symbolic links, which is annoying. The downside is that the copies of README.md now has to be separately updated, which isn't that big of a hassle compared to the problem that it fixes. [1] containers/buildah#1952 containers#723
debarshiray
force-pushed
the
wip/rishi/images-remove-symbolic-links
branch
from
b34dc5d to
a8c6fd1
Compare
martymichal
approved these changes
Mar 15, 2021
martymichal
added
2. Documentation
|
Build failed.
|
Member
Author
|
Thanks, @HarryMichal |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while ago, 'podman build' stopped supporting COPY with relative
symbolic links [1]. Therefore, these image definitions can't be used
without first temporarily removing the symbolic links, which is
annoying.
The downside is that the copies of README.md now has to be separately
updated, which isn't that big of a hassle compared to the problem that
it fixes.
[1] containers/buildah#1952