README.md, cmd/initContainer: Don't require /etc/machine-id in images#794
Merged
debarshiray merged 3 commits intocontainers:mainfrom Jun 22, 2021
Merged
Conversation
debarshiray
force-pushed
the
wip/rishi/mount-bind-handle-regular-files
branch
from
67291de to
1e3b388
Compare
|
Build failed.
|
martymichal
added
2. Container Configuration
Member
Author
Thanks for the review! |
A subsequent commit will handle a missing containerPath when bind mounting a regular file like /etc/machine-id. Therefore, it's better to explicitly state that this code is dealing with a directory. containers#710
Errors thrown from 'toolbox init-container' are usually not shown to the user. One has to use 'podman start --attach ...' to see them. Therefore, it's worth adding the extra bit of information to the error. containers#710
Since /etc/machine-id is bind mounted into the toolbox container from the host operating system, it doesn't make sense to make it mandatory for images to have that file. Apparently, (some?) Arch Linux images don't have /etc/machine-id. Since a missing containerPath for a directory is handled the same way, there's no reason not to do the same for regular files. It will make life a bit easier for those creating toolbox images for different distributions. containers#710
debarshiray
force-pushed
the
wip/rishi/mount-bind-handle-regular-files
branch
from
1e3b388 to
fb41179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
/etc/machine-idis bind mounted into the toolbox container fromthe host operating system, it doesn't make sense to make it mandatory
for images to have that file. Apparently, (some?) Arch Linux images
don't have
/etc/machine-id.Since a missing
containerPathfor a directory is handled the same way,there's no reason not to do the same for regular files. It will make
life a bit easier for those creating toolbox images for different
distributions.
#710