Skip to content

Fix/ECO-2473-npm-audit-fixed #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Contentstack-AnkitaD merged 2 commits into from
Mar 21, 2023
Merged

Fix/ECO-2473-npm-audit-fixed #66

Contentstack-AnkitaD merged 2 commits into from
Mar 21, 2023

Conversation

@Contentstack-AnkitaD
Copy link
Contributor

@Contentstack-AnkitaD Contentstack-AnkitaD commented Mar 20, 2023 •
edited
Loading

  • npm audit fixed

image

@Contentstack-AnkitaD Contentstack-AnkitaD requested a review from a team as a code owner March 20, 2023 14:33
@github-advanced-security
Copy link

github-advanced-security bot commented Mar 20, 2023

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Amitkanswal
Amitkanswal reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@Amitkanswal Amitkanswal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AniketDev7 I had a discussion with @surajcontentstack and we have decided to keep only one lock file. So except package-lock remove others

@Contentstack-AnkitaD Contentstack-AnkitaD marked this pull request as draft March 20, 2023 20:05
@Contentstack-AnkitaD Contentstack-AnkitaD marked this pull request as ready for review March 21, 2023 04:57
@Contentstack-AnkitaD Contentstack-AnkitaD merged commit bf1f406 into staging Mar 21, 2023
@Contentstack-AnkitaD Contentstack-AnkitaD deleted the fix/ECO-2473-framework-version-updates branch March 24, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhishek305 abhishek305 abhishek305 approved these changes

@sagar-gadekar sagar-gadekar Awaiting requested review from sagar-gadekar

@Amitkanswal Amitkanswal Awaiting requested review from Amitkanswal

+1 more reviewer

@surajcontentstack surajcontentstack surajcontentstack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Contentstack-AnkitaD @abhishek305 @Amitkanswal @surajcontentstack