Make runtime (un-)initialization implicit in most cases#72
Merged
Conversation
... and allow STA initialization (fixes contextfree#62).
rbtying
approved these changes
May 18, 2019
Contributor
rbtying
left a comment
rbtying
left a comment
There was a problem hiding this comment.
This looks generally reasonable to me from my understanding of COM/WinRT. Would we want to retain the RuntimeContext struct and mark it deprecated, for migration reasons?
Collaborator
Author
|
Generally in the Rust crate ecosystem there are no strong stability guarantees for pre-1.0 versions. At least that is my impression. The versions are not semver-compatible anyway, so I think a hard removal is not a problem. But you might be able to convince me otherwise ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and allow STA initialization (fixes #62).
@rbtying @BenJKuhn Can you have a look at this?