no api-proxy visible with kubeadm and minor tweaks#170
Open
chrisplo wants to merge 1 commit intocontiv:masterfrom
Open
no api-proxy visible with kubeadm and minor tweaks#170chrisplo wants to merge 1 commit intocontiv:masterfrom
chrisplo wants to merge 1 commit intocontiv:masterfrom
Conversation
With kubeadm, the api-proxy pod is not created as it's inside the netmaster container, documents did not reflect this. A list was not rendering properly. Some whitespaces issues, some wording wasn't clear Signed-off-by: Chris Plock <chrisplo@cisco.com>
vhosakot
approved these changes
Dec 2, 2017
Member
vhosakot
left a comment
vhosakot
left a comment
There was a problem hiding this comment.
👍 LGTM. Fast-merge it and save CI boxes!
Contributor
|
@chrisplo looks fine, but can you run It's fine to do that as a totally separate commit for readability. A lot of the previous PRs split the changes and codegen into separate commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With kubeadm, the api-proxy pod is not created as it's inside the
netmaster container, documents did not reflect this.
A list was not rendering properly.
Some whitespaces issues, some wording wasn't clear
Signed-off-by: Chris Plock chrisplo@cisco.com