Skip to content

feat(config-pnpm-scopes): allow global scope#4553

Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom
ya2s:master
Sep 29, 2025
Merged

feat(config-pnpm-scopes): allow global scope#4553
escapedcat merged 1 commit intoconventional-changelog:masterfrom
ya2s:master

Conversation

@ya2s
Copy link
Copy Markdown
Contributor

@ya2s ya2s commented Sep 29, 2025

Description

  • Deduplicate resolved workspace package names and always include a global scope.
  • Align the @commitlint/config-pnpm-scopes tests with the new global scope expectation.

When using a pnpm workspace, it’s not possible to specify a scope for file changes made directly under the root.
I used pnpm add --global as a reference and named the scope global.
https://pnpm.io/ja/cli/add#--global--g

Motivation and Context

The pnpm workspace root often needs commits that touch shared files. Without a shared scope option, commitlint rejects those messages. Adding global keeps the restriction for packages while enabling root-level changes.

Usage examples

// commitlint.config.js
module.exports = {
  extends: ["@commitlint/config-pnpm-scopes"],
};
echo "chore(global): update pnpm-workspace.yaml" | commitlint

How Has This Been Tested?

  • pnpm vitest run --environment node @commitlint/config-pnpm-scopes/index.test.ts
    • (fails in the sandbox because @commitlint/test cannot be resolved; please re-run in a full workspace environment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. (Unable to complete locally due to missing dependency in sandbox)

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Copy Markdown
Member

Sweet, thanks!

Do you know by any chance what to do with this?: #4525

@ya2s
Copy link
Copy Markdown
Contributor Author

ya2s commented Sep 29, 2025

@escapedcat
I’m not very familiar with this, so I can’t give a clear answer🙏

@escapedcat
Copy link
Copy Markdown
Member

No worries, just wanted to check :)

@escapedcat escapedcat merged commit e571970 into conventional-changelog:master Sep 29, 2025
21 of 22 checks passed
@ya2s
Copy link
Copy Markdown
Contributor Author

ya2s commented Sep 30, 2025

@escapedcat
Thank you for the merge!
When will the patch release be released?

immxmmi pushed a commit to immxmmi/gitea-helm-actions that referenced this pull request Apr 20, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [commitlint/commitlint](https://github.com/conventional-changelog/commitlint) | container | major | `19.9.1` -> `20.1.0` |

---

### Release Notes

<details>
<summary>conventional-changelog/commitlint (commitlint/commitlint)</summary>

### [`v20.1.0`](https://github.com/conventional-changelog/commitlint/blob/HEAD/CHANGELOG.md#2010-2025-09-30)

[Compare Source](conventional-changelog/commitlint@v20.0.0...v20.1.0)

##### Bug Fixes

- **resolve-extends:** add import attribute for JSON config files ([#&#8203;4551](conventional-changelog/commitlint#4551)) ([82936c9](conventional-changelog/commitlint@82936c9))

##### Features

- **config-pnpm-scopes:** allow global scope ([#&#8203;4553](conventional-changelog/commitlint#4553)) ([e571970](conventional-changelog/commitlint@e571970))

### [`v20.0.0`](https://github.com/conventional-changelog/commitlint/blob/HEAD/CHANGELOG.md#2000-2025-09-25)

[Compare Source](conventional-changelog/commitlint@v19.9.1...v20.0.0)

##### Bug Fixes

- update dependency tar-fs to v3.1.1 \[security] ([#&#8203;4550](conventional-changelog/commitlint#4550)) ([273a43e](conventional-changelog/commitlint@273a43e))

- feat(rules)!: make body-max-line-length ignore lines with URLs ([#&#8203;4486](conventional-changelog/commitlint#4486)) ([2f37a88](conventional-changelog/commitlint@2f37a88)), closes [#&#8203;4486](conventional-changelog/commitlint#4486)

##### BREAKING CHANGES

- when lines contain URLs exceeding the maximum
  line length `body-max-line-length` will be ignored

#### [19.9.1](conventional-changelog/commitlint@v19.9.0...v19.9.1) (2025-08-29)

##### Bug Fixes

- add TypeScript support and configuration for pnpm scopes ([#&#8203;4544](conventional-changelog/commitlint#4544)) ([ea75778](conventional-changelog/commitlint@ea75778))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - Only on Sunday and Saturday ( * * * * 0,6 ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xOC4xIiwidXBkYXRlZEluVmVyIjoiNDEuMTguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsia2luZC9kZXBlbmRlbmN5Il19-->

Reviewed-on: https://gitea.com/gitea/helm-actions/pulls/70
Reviewed-by: DaanSelen <daanselen@noreply.gitea.com>
Co-authored-by: Renovate Bot <renovate-bot@gitea.com>
Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants