Run moon from anywhere and make QoS reliability configurable #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Signed-off-by: Karim Pedemonte <karim.pedemonte@edu.unige.it>
Signed-off-by: Karim Pedemonte <karim.pedemonte@edu.unige.it>
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Signed-off-by: Marco Lampacrescia <marco.lampacrescia@de.bosch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moon is now installable as a PIP package, and can be run from anywhere in the system.
We made it compatible with venv, and we removed the need of copying properties files in specific folders.
In the configs, we introduced a new field in the config file for configuring the QoS reliability: the new field is
qos_reliability, and can be found in the exemplary configuration.Some updates in the ReadMe are probably still required.
Last but nor least, we removed the ROSMonitoring submodule, as we now copied the few files required in this package.