Make ServiceStats fields nullable to avoid zero-filled output (#183)#184
Open
aleivag wants to merge 1 commit into
Open
Make ServiceStats fields nullable to avoid zero-filled output (#183)#184aleivag wants to merge 1 commit into
aleivag wants to merge 1 commit into
Conversation
…lees#183) The varlink path creates ServiceStats entries for every service unit via NRestarts metrics, but only populates nrestarts — the remaining 15 fields were emitted as zeros. On a system with ~390 services this produced ~6,270 useless JSON keys. Making all ServiceStats fields Option<T> with skip_serializing_if means only fields with actual data are emitted. The D-Bus path wraps all values in Some(), so its output is unchanged. The varlink path now emits only nrestarts per service instead of 16 fields.
cooperlees
requested changes
May 16, 2026
Owner
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
As discussed, I think I'd rather fix or revert the change for this to try and use varlink if we can't fix it in the near term and just use dbus ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The varlink path creates ServiceStats entries for every service unit via NRestarts metrics, but only populates nrestarts — the remaining 15 fields were emitted as zeros. On a system with ~390 services this produced ~6,270 useless and false JSON keys.
Making all ServiceStats fields Option with skip_serializing_if means only fields with actual data are emitted. The D-Bus path wraps all values in Some(), so its output is unchanged. The varlink path now emits only nrestarts per service instead of 16 fields.
now we only produce 3224 metrics but they all are true