mantle/qemu: Rework API to allow setting Config after creation#1291
Conversation
First, we don't hard require a config, so there's no reason to force people to pass the empty string if they don't want one. Second, this is prep for further work on 9p mounts which want to build up a config and qemu arguments simultaneously.
|
Yup, makes a lot of sense to me! (This actually came up in a convo I had with @sohankunkerkar yesterday about how to test coreos/ignition#903; we'll want a way to boot a VM without any Ignition config.) /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To be clear that worked before this too, you just had to pass |
4 participants
First, we don't hard require a config, so there's no reason
to force people to pass the empty string if they don't want one.
Second, this is prep for further work on 9p mounts which want
to build up a config and qemu arguments simultaneously.