mantle/ore: gcloud: clean up upload.go, stop mutating image name#1322
Merged
openshift-merge-robot merged 2 commits intocoreos:masterfrom Apr 7, 2020
Merged
Conversation
- Don't try to detect or set defaults for bucket, name, or file arguments. - Don't try to set a default prefix/path to use in GS buckets
Before this commit if I try to upload to gs://mybucket/fedora-coreos my image name would get rewritten to append the path `fedora-coreos` into the image name. For example: - `fedora-coreos-31-20200404-dev-1-gcp-x86-64` turns into - `fedora-coreos-fedora-coreos-31-20200404-dev-1-gcp-x86-64` This was introduced in d98ec2e and doesn't seem to be needed. Let's rework it so that transformation doesn't happen.
dustymabe
force-pushed
the
dusty-mantle-gcloud-upload-cleanup
branch
from
bfb094c to
32b0062
Compare
Member
Author
Member
Author
|
cc @cgwalters - any issues with that second commit for the RHCOS pipeline? |
Contributor
|
/approve |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgilbert, cgwalters, dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanup in here to remove CL specific bits and change the code from mutating the image name on upload. See the individual commit messages for more info.