kola: Test interactive ISO login without networking#1330
kola: Test interactive ISO login without networking#1330openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
cgwalters
force-pushed
the
testiso-nonet-interactive
branch
from
82c88ce to
061f782
Compare
|
OK, tested and working in concert with coreos/fedora-coreos-config#339 ! |
cgwalters
changed the title
| } | ||
|
|
||
| // SerialPipe reads the serial console output into a pipe | ||
| func (builder *QemuBuilder) SerialPipe() (*os.File, error) { |
There was a problem hiding this comment.
This is no longer used in this PR but I kept it because it'll surely be useful later.
cgwalters
force-pushed
the
testiso-nonet-interactive
branch
from
061f782 to
544e488
Compare
cgwalters
force-pushed
the
testiso-nonet-interactive
branch
from
544e488 to
024ae70
Compare
|
OK the only reason the test was passing here is I'd forgotten to add it to default scenario list. But now that coreos/fedora-coreos-config#339 has merged, let's give it a try. (That said until we start pinning cosa in the FCOS pipeline this could start failing on the prod pipelines that won't have that change) |
I initially thought we could just scrape the text serial console but the ISO doesn't output there by default 😢 Instead, this now depends on coreos/fedora-coreos-config#339
cgwalters
force-pushed
the
testiso-nonet-interactive
branch
from
024ae70 to
64bd888
Compare
|
🎉 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
I initially thought we could just scrape the text serial
console but the ISO doesn't output there by default cry
Instead, this now depends on coreos/fedora-coreos-config#339