Skip to content

cmd-fetch: add --strict for fetching in strict mode#1378

Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom
dustymabe:dusty-strict-fetch
Apr 21, 2020
Merged

cmd-fetch: add --strict for fetching in strict mode#1378
openshift-merge-robot merged 1 commit intocoreos:masterfrom
dustymabe:dusty-strict-fetch

Conversation

@dustymabe
Copy link
Copy Markdown
Member

@dustymabe dustymabe commented Apr 21, 2020

Similar to b2355e7 for cosa build let's add a --strict for
fetching in strict mode. Without this we were seeing issues where
fetching would fetch a different set of packages than "build" needed
in order to do the build.

@dustymabe dustymabe changed the title cmd-fetch: add --strict for building in strict mode cmd-fetch: add --strict for fetching in strict mode Apr 21, 2020
@dustymabe dustymabe force-pushed the dusty-strict-fetch branch from 0f0be68 to 788bd06 Compare April 21, 2020 00:54
@dustymabe
Copy link
Copy Markdown
Member Author

dustymabe commented Apr 21, 2020 •
edited
Loading

link to an example run where fetch and build didn't return the same package set which led to build failing because of no network. For this run libbrotli-1.0.7-10.fc32.x86_64 (fedora-coreos-pool) was fetched during the fetch stage but brotli-1.0.7-6.fc31.x86_64 (fedora-coreos-pool) was required during the strict build phase. Once we update the fetch to be strict too this should not be a problem.

dustymabe added a commit to dustymabe/fedora-coreos-pipeline that referenced this pull request Apr 21, 2020
@dustymabe
pipeline: use cosa fetch --strict
dc20e6c 
We also need to fetch in strict mode. This requires [1]. See that PR
for more information.

[1] coreos/coreos-assembler#1378
@dustymabe dustymabe mentioned this pull request Apr 21, 2020
Merged
@dustymabe
cmd-fetch: add --strict for fetching in strict mode
f23aad7 
Similar to b2355e7 for `cosa build` let's add a --strict for
fetching in strict mode. Without this we were seeing issues where
fetching would fetch a different set of packages than "build" needed
in order to do the build.
@dustymabe dustymabe force-pushed the dusty-strict-fetch branch from 788bd06 to f23aad7 Compare April 21, 2020 01:09
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Apr 21, 2020

Ahh yup, good catch. Thanks!
/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4f60635 into coreos:master Apr 21, 2020
@dustymabe dustymabe mentioned this pull request Apr 21, 2020
Merged
@dustymabe dustymabe deleted the dusty-strict-fetch branch April 21, 2020 13:11
dustymabe added a commit to coreos/fedora-coreos-pipeline that referenced this pull request Apr 21, 2020
@dustymabe
pipeline: use cosa fetch --strict
62061e7 
We also need to fetch in strict mode. This requires [1]. See that PR
for more information.

[1] coreos/coreos-assembler#1378
@jlebon jlebon mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

@miabbott miabbott Awaiting requested review from miabbott

Assignees

@jlebon jlebon

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dustymabe @jlebon @openshift-ci-robot @openshift-merge-robot