build: Run udevd in supermin appliance#1386
Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom Apr 22, 2020
Merged
build: Run udevd in supermin appliance#1386openshift-merge-robot merged 1 commit intocoreos:masterfrom
openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
A lot of our code wants things like `/dev/disk/by-X`. Extracted from coreos#1244
cgwalters
commented
Apr 22, 2020
| #!/usr/bin/env bash | ||
| # This script is our half-baked ad-hoc reimplementation of a minimal | ||
| # Linux boot environment that we generate via `supermin`. At some | ||
| # point we will likely switch to using systemd. |
Member
Author
There was a problem hiding this comment.
(BTW, I think the best fix here is to generate a minimal initramfs that mounts the host (container) filesystem via virtiofs/9p. Then we really don't need supermin at all, we can use systemd etc. when we're building the ostree-based disk image, etc.)
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of our code wants things like
/dev/disk/by-X. Extractedfrom #1244