build: Don't auto-load qemu image when building#1390
Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom Apr 23, 2020
Merged
build: Don't auto-load qemu image when building#1390openshift-merge-robot merged 1 commit intocoreos:masterfrom
openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
Regression from coreos#1289 that probably explains other mysterious problems I was seeing too. Basically, if a qemu image already existed, we would auto-load it with `kola qemuexec`. In the case of builds, we absolutely do not want to do that. I probably didn't see this *initially* when working on this because my build didn't have a qemu image yet.
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #1289
that probably explains other mysterious problems I was seeing too.
Basically, if a qemu image already existed, we would auto-load it
with
kola qemuexec. In the case of builds, we absolutely do notwant to do that.
I probably didn't see this initially when working on this because
my build didn't have a qemu image yet.