cmdlib: Don't dump serial console to stdout#1392
Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom Apr 27, 2020
Merged
cmdlib: Don't dump serial console to stdout#1392openshift-merge-robot merged 1 commit intocoreos:masterfrom
openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
jlebon
reviewed
Apr 24, 2020
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
No more messed up terminal = win!
In coreos#1338 we fixed the problem of having one's terminal be corrupted by the serial console. This fixes the same problem for `cosa build` which ends up running a VM too. First, there's no real reason to dump the kernel bootup output to the terminal (or build logs) - it's totally uninteresting stuff that we only want to see if something fails. Gather the serial console to one log file, and the output of the *command* we run in the VM to another. Fork off a `tail` process to follow just the command output. (When we rewrite this in a better language we will do this properly async)
Member
|
Tested this locally too. Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
possible fallout: coreos/fedora-coreos-config#365 (comment) |
Member
|
Follow-up: #1403 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1338
we fixed the problem of having one's terminal be corrupted
by the serial console.
This fixes the same problem for
cosa buildwhich ends uprunning a VM too. First, there's no real reason to dump
the kernel bootup output to the terminal (or build logs) - it's
totally uninteresting stuff that we only want to see if
something fails.
Gather the serial console to one log file, and the output of
the command we run in the VM to another. Fork off a
tailprocess to follow just the command output. (Whenwe rewrite this in a better language we will do this properly
async)