oscontainer: Use podman push --digestfile#1503
Closed
cgwalters wants to merge 2 commits intocoreos:masterfrom
Closed
oscontainer: Use podman push --digestfile#1503cgwalters wants to merge 2 commits intocoreos:masterfrom
cgwalters wants to merge 2 commits intocoreos:masterfrom
Conversation
In general we should avoid doing any nontrivial networking in supermin because usermode networking is slow. Further, as of OpenShift 4 it's documented how to use `buildah` inside OpenShift, so let's do that rather than supermin. Motivated by debugging why the oscontainer push in the RHCOS pipeline is 2 hours. Closes: coreos#1500
A while ago, we were using `skopeo inspect` as part of `pivot` for OpenShift 4 OS upgrades, and it turns out that enumerates all tags, which is expensive and rate limited by quay.io: openshift/pivot#51 The RHCOS oscontainer builds have been failing in `skopeo inspect` and I suspect it's related to this. It looks like nowadays podman has `--digestfile` which is exactly what we want here, so let's use it and drop the `skopeo`. This simplifies the code too.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
Decided to fold this into #1502 for simplicity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends #1502
A while ago, we were using
skopeo inspectas part ofpivotfor OpenShift 4 OS upgrades, and it turns out that enumerates
all tags, which is expensive and rate limited by quay.io:
openshift/pivot#51
The RHCOS oscontainer builds have been failing in
skopeo inspectand I suspect it's related to this.
It looks like nowadays podman has
--digestfilewhich isexactly what we want here, so let's use it and drop the
skopeo.This simplifies the code too.