Skip to content

Adds qemu wrapper to disable pmu in cpu flags #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dustymabe merged 1 commit into from
Nov 15, 2018
Merged

Adds qemu wrapper to disable pmu in cpu flags #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/gf-oemid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,29 @@ oemid="$3"
set -x
tmpd=$(mktemp -td gf-oemid.XXXXXX)
tmp_dest=${tmpd}/box.img

# Work around for https://github.com/coreos/coreos-assembler/issues/198
Comment thread
dcode marked this conversation as resolved.
# performance monitoring for nested virtualization doesn't work reliably on
# different hypervisors (VMWare, VirtualBox, etc) so just disable the pmu
qemu_wrapper=${tmpd}/qemu-wrapper.sh
cat <<'EOF' > "${qemu_wrapper}"
#!/usr/bin/bash -
i=0
while [ $# -gt 0 ]; do
case "$1" in
-cpu)
shift 2;;
*)
args[i]="$1"
(( i++ ))
shift ;;
esac
done
exec qemu-kvm -cpu host,pmu=off "${args[@]}"
EOF
chmod +x "${qemu_wrapper}"
export LIBGUESTFS_HV="${qemu_wrapper}"

cp --reflink=auto "${src}" "${tmp_dest}"
# <walters> I commonly chmod a-w VM images
chmod u+w "${tmp_dest}"
Expand Down