4.7: Allow for setting virtual_size per qemu variant#2042
Merged
openshift-merge-robot merged 2 commits intocoreos:rhcos-4.7from Feb 12, 2021
Merged
Conversation
When provided with a virtual_size directive we now resize the qemu image before converting the image. (cherry picked from commit 19cba94)
Images builds which symlink to cmd-artifact-disk can optionally provide a virtual_size in their variant configuration. When in manual mode the --virtual-size switch can be used directly. (cherry picked from commit aa2ea67)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, ravanelli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2041. Same local test was done.
Description
Add the ability to set the virtual size in the qemu variant configuration or via a switch in manual mode when using
cmd-artifact-disk. This also sets the default virtual size foribmcloudartifacts to 100G per request.Test
Done via a local build off the main branch.