buildextend-live: add --miniso switch#2466
Merged
jlebon merged 3 commits intocoreos:mainfrom Oct 3, 2021
Merged
Conversation
Contributor
|
Could we just skip the system area tweaking for the minimal ISO? That code will be going away in #2455 anyway, and any coreos-installer release that supports miniso generation will also support new-style Ignition/kargs embedding. |
Member
Author
Yup, good call! I'll rebase coreos/coreos-installer#559 on top of coreos/coreos-installer#622 then update this one. |
Member
Author
|
Updated! |
cgwalters
previously approved these changes
Oct 1, 2021
bgilbert
reviewed
Oct 1, 2021
Since ba15feb, the Ignition config is now a bona fide file on the live ISO rather than just padding to the existing initramfs image. Update the comments and variable names to reflect this.
This switch enables the new minimal ISO packing feature (see coreos/coreos-installer#559). Once a coreos-installer version with miniso support is present in RHCOS and FCOS, we can make it unconditional and drop the switch. For now, this will allow testing in the coreos-installer upstream CI.
This is like `iso-install`, but exercises the minimal ISO workflow instead. Also, confusingly the install itself is offline, though it does need networking to fetch the rootfs. See comment block about this in `InstallViaISOEmbed`.
Member
Author
|
Updated for comments! |
bgilbert
approved these changes
Oct 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switch enables the new minimal ISO packing feature (see
coreos/coreos-installer#559).
Once a coreos-installer version with miniso support is present in RHCOS
and FCOS, we can make it unconditional and drop the switch. For now,
this will allow testing in the coreos-installer upstream CI.