[rhcos-4.10] cmdlib: consistently commit layers with same options#2706
Conversation
|
Hi @openshift-cherrypick-robot. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
Make a helper for committing OSTree layers which contains all the canonicalization flags. Notably `--timestamp` which ensures that we get a consistent checksum for the same source git commit. Fixes: openshift/os#712 Fixes: coreos#2603
openshift-cherrypick-robot
force-pushed
the
cherry-pick-2703-to-rhcos-4.10
branch
from
bf0c828 to
e2c6b94
Compare
|
|
Yeah, you're right. Let's reflect agreement here too instead of just having it live in Slack. /lgtm cancel |
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
We don't actually use lgtm here anyways though right? But lgtm.
|
CoreOS CI doesn't work correctly on branches. /override continuous-integration/jenkins/pr-merge |
|
@jlebon: Overrode contexts on behalf of jlebon: continuous-integration/jenkins/pr-merge DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This is an automated cherry-pick of #2703
/assign jlebon