Clean up POWER wrapper in libguestfish#2718
Merged
jlebon merged 1 commit intocoreos:mainfrom Feb 22, 2022
Merged
Conversation
- It is a follow up for the issue openshift/os#720 and for coreos#2714 - POWER never really used the newGuestfish function in mantle/platform/qemu.go, with the new tests now using setupPreboot function that was recently added, the issue happened because there is no call for the POWER wrapper in the newGuestfish. Nonetheless, it is not a libguestfish issue since POWER8 (cluster) needs the vsmt set to 8. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Member
Author
|
/retest-required |
Member
|
I think the And since this PR really doesn't touch the |
Member
|
/override ci/prow/rhcos |
|
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a follow up for the issue RHCOS 4.11 ppc64le test failures due to
libguestfserrors? openshift/os#720 and for Add libguestfs workaround for ppc64le #2714POWER never really used the newGuestfish function in
mantle/platform/qemu.go, with the new tests now using setupPreboot function
that was recently added, the issue happened because there is no call for the
POWER wrapper in the newGuestfish. Nonetheless, it is not a libguestfish issue
since POWER8 (cluster) needs the vsmt set to 8.
Signed-off-by: Renata Ravanelli rravanel@redhat.com