build: Support builds/ in workdir being a symlink outside workdir#2774
Merged
jlebon merged 1 commit intocoreos:mainfrom Mar 23, 2022
Merged
build: Support builds/ in workdir being a symlink outside workdir#2774jlebon merged 1 commit intocoreos:mainfrom
builds/ in workdir being a symlink outside workdir#2774jlebon merged 1 commit intocoreos:mainfrom
Conversation
This is the case in the RHCOS pipeline today, and we can support it in the same way we support `src/config` being a symlink to outside the workdir. Note: This only works for absolute symlinks today. Side note: At some point we should use virtiofs which AIUI will just fix this by supporting symlinks natively. Closes: openshift/os#754
Member
Author
|
To test this locally, I did: It failed without this patch, and succeeded with. |
jlebon
approved these changes
Mar 23, 2022
miabbott
approved these changes
Mar 23, 2022
Member
miabbott
left a comment
miabbott
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the quick turnaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the case in the RHCOS pipeline today, and we can support
it in the same way we support
src/configbeing a symlink tooutside the workdir.
Note: This only works for absolute symlinks today.
Side note: At some point we should use virtiofs which AIUI will
just fix this by supporting symlinks natively.
Closes: openshift/os#754