Makefile: check that schema copies are synced#2808
Merged
jlebon merged 1 commit intocoreos:mainfrom Apr 11, 2022
bgilbert:schema
Merged
Makefile: check that schema copies are synced#2808jlebon merged 1 commit intocoreos:mainfrom bgilbert:schema
jlebon merged 1 commit intocoreos:mainfrom
bgilbert:schema
Conversation
On a number of occasions, we've forgotten to synchronize the various copies of v1.json and the files generated from them. We should reduce the number of copies we carry, but for now, have CI check that all copies are in sync. Add source hashes to the generated files so we can check that the latter are up-to-date without regenerating them.
cgwalters
approved these changes
Apr 10, 2022
jlebon
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a number of occasions, we've forgotten to synchronize the various copies of
v1.jsonand the files generated from them. We should reduce the number of copies we carry, but for now, have CI check that all copies are in sync. Add source hashes to the generated files so we can check that the latter are up-to-date without regenerating them.