Require platforms.yaml in config#2899
Merged
bgilbert merged 1 commit intocoreos:mainfrom Jan 11, 2023
bgilbert:console-legacy
Merged
Require platforms.yaml in config#2899bgilbert merged 1 commit intocoreos:mainfrom bgilbert:console-legacy
platforms.yaml in config#2899bgilbert merged 1 commit intocoreos:mainfrom
bgilbert:console-legacy
Conversation
|
Skipping CI for Draft Pull Request. |
cgwalters
previously approved these changes
Jun 2, 2022
Member
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Looks sane to me at a high level.
|
@bgilbert: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Both FCOS and RHCOS ship it now. Drop the fallback to the legacy console configuration when platforms.yaml is missing.
Contributor
Author
|
Okay, ready for review! |
jlebon
approved these changes
Jan 5, 2023
Member
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that both FCOS and RHCOS ship
platforms.yaml, we can drop the fallback to the legacy console configuration when that file is missing.