metal.go: remove optional rom pxe-rtl8139 #2964
Conversation
saqibali-2k
force-pushed
the
pr/fix-pxe-rom-notfound
branch
from
c2d8979 to
f1cef3f
Compare
|
Last push fixes a typo in the commit message. |
To me this fact begs a few questions:
|
The answer seems to be "no"...that said I think the answer is this bit of code above: And I suspect it's something like the e1000 drivers being built into ipxe, so this secondary NIC driver was never needed. |
|
/retest |
|
We did some more digging on this the other day. @saqibali-2k is going to post an update |
The `-option-rom .../pxe-rtl8139.rom` used to be required but is no longer needed because according to [1] "If no rom bar is specified, the qemu default will be used (older versions of qemu used a default of "off", while newer qemus have a default of "on")". The attribute `file` which is used to pass an [1] `alternative boot ROM for a network device` is optional and thus assumed to have a default in QEMU. So now qemu will default to loading the option rom for the given NIC device model. [1] https://gitlab.com/libvirt/libvirt/-/blob/3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29/docs/formatdomain.rst#interface-rom-bios-configuration fixes: coreos#2918
saqibali-2k
force-pushed
the
pr/fix-pxe-rom-notfound
branch
from
f1cef3f to
3be34d3
Compare
|
/override ci/prow/rhcos |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Excellent investigation and commit message!
Credit goes to Dusty :) |
|
/retest |
saqibali-2k
changed the title
|
RHCOS is broken until openshift/os#890 is merged |
|
@saqibali-2k: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
which I think means we can ignore this CI failure. |
5 participants
The
-option-rom .../pxe-rtl8139.romused to be required but is nolonger needed because according to [1] "If no rom bar is specified,
the qemu default will be used (older versions of qemu used a default
of "off", while newer qemus have a default of "on")".
The attribute
filewhich is used to pass an [1]alternative boot ROM for a network deviceis optional and thusassumed to have a default in QEMU.
So now qemu will default to loading the option rom for the given NIC
device model.
[1] https://gitlab.com/libvirt/libvirt/-/blob/3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29/docs/formatdomain.rst#interface-rom-bios-configuration
fixes: #2918