Skip to content

buildextend-extensions: Copy repofiles to tmpdir#3075

Merged
travier merged 1 commit intocoreos:mainfrom
travier:repo-tmpdir
Sep 12, 2022
Merged

buildextend-extensions: Copy repofiles to tmpdir#3075
travier merged 1 commit intocoreos:mainfrom
travier:repo-tmpdir

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Sep 5, 2022

Fixes: #3074
Fixes: #3045

@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 5, 2022

Needs testing.

cgwalters
cgwalters previously approved these changes Sep 6, 2022
@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 7, 2022

Updated. Thanks @HuijingHei !

@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 7, 2022

Hum, this is apparently not the full fix

@travier travier marked this pull request as draft September 7, 2022 15:59
@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 7, 2022

This is a fallout from #3036

@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 7, 2022

Workaround is to copy the repo definitions into the config repo for now. I'm giving up on this one for now. We'll discuss how to move forward once @jlebon comes back.

@travier travier marked this pull request as ready for review September 7, 2022 17:29
@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 7, 2022

Found another workaround but the more it goes the more it goes, the lesser I like our current hacks. The Go/Python/Shell split does not help for sure.

Copy repo config files from config dir & yumrepos git repo.

Fixes: coreos#3074
Fixes: coreos#3036
Fixes: coreos#3045
Copy link
Copy Markdown
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting this will become dead code once machine-os-content goes away - the new flow is https://github.com/coreos/coreos-assembler/blob/main/cmd/build-extensions-container.go

I only gave this a superficial glance but it looks sane.

At some point we probably need to teach the CI here to use the separate repos flow.

@travier travier merged commit 5c708b4 into coreos:main Sep 12, 2022
@travier travier deleted the repo-tmpdir branch September 12, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cosa buildextend-extensions does not uses the repos from `yumrepo option with a custom variant

2 participants