Remove tools/, install schematyper on demand#3093
Merged
dustymabe merged 1 commit intocoreos:mainfrom Sep 13, 2022
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
cgwalters
changed the title
Member
|
LGTM - thanks for working on this and minimizing what gets pulled from the internet during our builds. |
We've had a few build/CI flakes due to the `go install` invocations happening as part of a build. We previously removed `gomarkdoc`, this completes things and stops building/installing `schematyper` by default. It's only need for developers to regenerate the schema; we commit the generated code, so we don't need to build or ship it by default.
cgwalters
force-pushed
the
schematyper-on-demand
branch
from
d8986be to
6b30d19
Compare
Member
Author
|
Rebased 🏄 and lifting draft |
Member
Author
|
CI flaked on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends #3092
Remove
tools/, install schematyper on demandWe've had a few build/CI flakes due to the
go installinvocationshappening as part of a build. We previously removed
gomarkdoc,this completes things and stops building/installing
schematyperby default.
It's only need for developers to regenerate the schema; we commit
the generated code, so we don't need to build or ship it by default.