tests: Stop checking for iscsid being disabled#3275
Merged
cgwalters merged 1 commit intocoreos:mainfrom Dec 12, 2022
Merged
Conversation
Having socket units enabled in particular is standard and expected. Every one of these should have had an explicit rationale. In this case, the rationale is probably lost to time. This fixes a test failure on rhel9.
jlebon
approved these changes
Dec 12, 2022
Member
|
/cherry-pick rhcos-4.12 |
Member
|
My bad we don't have Prow here |
|
@travier: new pull request created: #3286 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
Oh, we do :) 🎉 |
jlebon
added a commit
to jlebon/os
that referenced
this pull request
May 26, 2023
The iSCSI daemon is now socket-activated so that it's only running when needed rather than always enabled. We're breaking that by disabling `iscsid.socket`. This effectively reverts 929ac48 ("c9s: Disable iscsid.socket"). It's not certain why this was done, but it was likely to workaround failing tests. These tests should be fixed now[[1]] so we should be able to stop doing this. [1]: coreos/coreos-assembler#3275
jlebon
added a commit
to jlebon/os
that referenced
this pull request
May 26, 2023
The iSCSI daemon is now socket-activated so that it's only running when needed rather than always enabled. We're breaking that by disabling `iscsid.socket`. This effectively reverts 929ac48 ("c9s: Disable iscsid.socket"). It's not certain why this was done, but it was likely to workaround failing tests. These tests should be fixed now[[1]] so we should be able to stop doing this. [1]: coreos/coreos-assembler#3275
jlebon
added a commit
to jlebon/os
that referenced
this pull request
May 29, 2023
The iSCSI daemon is now socket-activated so that it's only running when needed rather than always enabled. We're breaking that by disabling `iscsid.socket`. This effectively reverts 929ac48 ("c9s: Disable iscsid.socket"). It's not certain why this was done, but it was likely to workaround failing tests. These tests should be fixed now[[1]] so we should be able to stop doing this. [1]: coreos/coreos-assembler#3275
travier
pushed a commit
to travier/os
that referenced
this pull request
Jun 1, 2023
The iSCSI daemon is now socket-activated so that it's only running when needed rather than always enabled. We're breaking that by disabling `iscsid.socket`. This effectively reverts 929ac48 ("c9s: Disable iscsid.socket"). It's not certain why this was done, but it was likely to workaround failing tests. These tests should be fixed now[[1]] so we should be able to stop doing this. [1]: coreos/coreos-assembler#3275 (cherry picked from commit 8c94270)
travier
pushed a commit
to travier/os
that referenced
this pull request
Jun 8, 2023
The iSCSI daemon is now socket-activated so that it's only running when needed rather than always enabled. We're breaking that by disabling `iscsid.socket`. This effectively reverts 929ac48 ("c9s: Disable iscsid.socket"). It's not certain why this was done, but it was likely to workaround failing tests. These tests should be fixed now[[1]] so we should be able to stop doing this. [1]: coreos/coreos-assembler#3275 (cherry picked from commit 8c94270)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having socket units enabled in particular is standard and expected. Every one of these should have had an explicit rationale. In this case, the rationale is probably lost to time.
This fixes a test failure on rhel9.
Closes: openshift/os#1016