Skip to content

[rhcos-4.13] ignition-gpg-key: Skip compression of ignition protection gpg key#3414

Merged
jschintag merged 2 commits intocoreos:rhcos-4.13from
jschintag:rhcos-4.13-skip-compression-ignition-key
Mar 31, 2023
Merged

[rhcos-4.13] ignition-gpg-key: Skip compression of ignition protection gpg key#3414
jschintag merged 2 commits intocoreos:rhcos-4.13from
jschintag:rhcos-4.13-skip-compression-ignition-key

Conversation

@jschintag
Copy link
Copy Markdown
Contributor

There is no need to compress the gpg public key, as that only adds more complexity for no gain.

cherry-picked from #3413

There is no need to compress the gpg public key, as that only adds more
complexity for no gain.

cherry-picked from coreos#3413

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 30, 2023

/approve
/lgtm
/override ci/prow/rhcos

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 30, 2023

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos

Details

In response to this:

/approve
/lgtm
/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Looks like I bumped down memory a bit too much in 511a61d
(".cci.Jenkinsfile: drop Fedora CoreOS testing"). We saw unit tests
getting OOM-killed. Bump it to 3Gi.
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 30, 2023

/lgtm
/approve
/override ci/prow/images

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 30, 2023

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/images

Details

In response to this:

/lgtm
/approve
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 30, 2023

Hmm, you don't seem to be a collaborator, so CoreOS CI isn't picking up the changes to .cci.jenkinsfile I pushed to this PR (see https://github.com/coreos/coreos-ci/blob/main/README-upstream-ci.md#contributor-trust). Anyway, CI doesn't test s390x, so

/override continuous-integration/jenkins/pr-merge
/override ci/prow/rhcos

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 30, 2023

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos, continuous-integration/jenkins/pr-merge

Details

In response to this:

Hmm, you don't seem to be a collaborator, so CoreOS CI isn't picking up the changes to .cci.jenkinsfile I pushed to this PR (see https://github.com/coreos/coreos-ci/blob/main/README-upstream-ci.md#contributor-trust). Anyway, CI doesn't test s390x, so

/override continuous-integration/jenkins/pr-merge
/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jschintag jschintag merged commit 34a1147 into coreos:rhcos-4.13 Mar 31, 2023
@jschintag jschintag deleted the rhcos-4.13-skip-compression-ignition-key branch March 31, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants