Skip to content

Stop bumping aarch64 to 8G automatically#3617

Merged
dustymabe merged 1 commit into
coreos:mainfrom
jlebon:pr/aarch64-64kpages
Sep 15, 2023
Merged

Stop bumping aarch64 to 8G automatically#3617
dustymabe merged 1 commit into
coreos:mainfrom
jlebon:pr/aarch64-64kpages

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Sep 14, 2023

The aarch64 RHEL8 kernel used a page size of 64K. In RHEL9, this was
lowered to the usual 4K and a separate kernel was added for 64K.

For testing, this now means that we no longer need to double the memory
for aarch64 by default like we do for ppc64le. If we write tests that
make use of the 64K kernel, we can have them request more memory as
needed.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Sep 14, 2023

Got all tests passing on aarch64 with this.

Works on top of #3611.

dustymabe
dustymabe previously approved these changes Sep 14, 2023
Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The aarch64 RHEL8 kernel used a page size of 64K. In RHEL9, this was
lowered to the usual 4K and a separate kernel was added for 64K.

For testing, this now means that we no longer need to double the memory
for aarch64 by default like we do for ppc64le. If we write tests that
make use of the 64K kernel, we can have them request more memory as
needed.
@jlebon jlebon dismissed dustymabe’s stale review September 14, 2023 20:26

The merge-base changed after approval.

@jlebon jlebon force-pushed the pr/aarch64-64kpages branch from e974ee6 to a659e9e Compare September 14, 2023 20:26
@jlebon jlebon marked this pull request as ready for review September 14, 2023 20:27
Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit c9e0d52 into coreos:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants