Add cosa supermin-run#3747
Conversation
jlebon
force-pushed
the
pr/supermin-script
branch
from
c286eb2 to
8fa183b
Compare
This is very close to `cosa supermin-shell` but instead expects a command to run inside the supermin VM. Essentially, it's a very thin wrapper around the `runvm` family of functions in `cmdlib.sh`. By having it be a dedicated function, it becomes like a utility command to have easy access to a privileged environment, with the working dir automatically mounted in, podman remote proxying, etc... Note also this *does not* require a cosa workdir. The podman machine OS pipeline will be using this temporarily.
In a cosa workdir, that dir always exists in both privileged and unprivileged paths. Prep for a new command that'll use this code outside a cosa workdir where to be nice we don't want to just randomly create a cache dir even when no caching is required.
jlebon
force-pushed
the
pr/supermin-script
branch
from
8fa183b to
f6f50a6
Compare
| fi | ||
| done | ||
|
|
||
| mkdir -p "${workdir}"/cache |
There was a problem hiding this comment.
sometimes I just rm -rf cache/ to blow away things to get a clean slate. I'm guessing something else would create it somewhere else in the stack, but...
could we just move this into the if statement below? if there is a cachedev and somehow the cache dir doesn't exist we'd surely want to create it, right?
There was a problem hiding this comment.
Hmm, but the cache/ dir must already exist at that point if using a cache qcow2, since the qcow2 is located there, right?
There was a problem hiding this comment.
right. but sometimes we don't use the cache qcow and things use the directory anyway?
There was a problem hiding this comment.
Hmm, I feel like whatever/whoever does rm -rf cache/ should ensure to recreate it. E.g. rpm-ostree today will error out trying to cache things there. But not against adding a mkdir -p cache somewhere in cmdlib.sh too.
|
/cherry-pick 4.15 |
|
@jlebon: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick rhcos-4.15 |
|
@jlebon: new pull request created: #3901 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick rhcos-4.14 |
|
@jlebon: new pull request created: #3902 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick rhcos-4.13 |
|
@jlebon: new pull request created: #3903 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick rhcos-4.12 |
|
@jlebon: new pull request created: #3904 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
This is very close to
cosa supermin-shellbut instead expects a command to run inside the supermin VM. Essentially, it's a very thin wrapper around therunvmfamily of functions incmdlib.sh.By having it be a dedicated function, it becomes like a utility command to have easy access to a privileged environment, with the working dir automatically mounted in, podman remote proxying, etc... Note also this does not require a cosa workdir.
The podman machine OS pipeline will be using this temporarily.