src/cmd-koji-upload: port to Python3#729
Merged
cgwalters merged 5 commits intocoreos:masterfrom Sep 4, 2019
darkmuggle:koji-py3
Merged
src/cmd-koji-upload: port to Python3#729cgwalters merged 5 commits intocoreos:masterfrom darkmuggle:koji-py3
cgwalters merged 5 commits intocoreos:masterfrom
darkmuggle:koji-py3
Conversation
Contributor
Author
|
This is a WIP for now, but I wanted to socialize the thinking in light of #720. I've included some of @cgwalters's changes. This is functional, but a full-end-to-end run has not been done. |
cgwalters
reviewed
Aug 29, 2019
Member
|
Oh man if it's this easy, great! |
Member
|
Quoth travis:
... Did you mean |
arithx
reviewed
Aug 29, 2019
ashcrow
reviewed
Aug 29, 2019
|
|
||
| # os.path.getsize uses 1kB instead of 1KB. So we use stat instead. | ||
| fsize = subprocess.check_output(["stat", "--dereference", "--format", '%s', lpath]) | ||
| fsize = '{}'.format(os.stat(lpath).st_size) |
ashcrow
reviewed
Aug 29, 2019
added 4 commits
September 4, 2019 11:47
The capsys module does not capture the output of `raise SystemExec(msg)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest Koji packages in Fedora just work with Kerberos authentication for Koji. This drops the Python2 for Python3.