Skip to content

Added logout functionality through provider#226

Open
dlouwers wants to merge 2 commits into
coreos:v2from
dlouwers:logout-endpoint
Open

Added logout functionality through provider#226
dlouwers wants to merge 2 commits into
coreos:v2from
dlouwers:logout-endpoint

Conversation

@dlouwers
Copy link
Copy Markdown

Replacement for #190 since I need to create more pull requests now

@dlouwers
Copy link
Copy Markdown
Author

Seems to be an issue with the Go 1,9 build. Unclear what since it is the same PR that passed but from a different branch: The command "go get -v -t github.com/coreos/go-oidc/..." failed and exited with 2 during .

@SachinVarghese
Copy link
Copy Markdown

@dlouwers Hey any updates on this? We are working on a similar use case where we need a redirect to a logout URL.

@brocaar
Copy link
Copy Markdown

brocaar commented Aug 4, 2020

@dlouwers is there any update on this? It looks like the Go 1.9 error causing the build to fail is:

../../../gopkg.in/square/go-jose.v2/encoding.go:58:9: undefined: strings.Builder

I'm looking forward to use this feature :)

@StiviiK
Copy link
Copy Markdown

StiviiK commented Aug 5, 2020

@dlouwers is there any update on this? It looks like the Go 1.9 error causing the build to fail is:

../../../gopkg.in/square/go-jose.v2/encoding.go:58:9: undefined: strings.Builder

I'm looking forward to use this feature :)

You need to use Go 1.10+ as this was added with Go 1.10
https://stackoverflow.com/questions/48978414/golang-strings-builder-type-undefined

@brocaar
Copy link
Copy Markdown

brocaar commented Aug 5, 2020

Would re-running the tests be the solution (and resolve the merge conflict)? Looks like Travis CI config has been updated to Go 1.12 and Go 1.13 since the test failed: https://github.com/coreos/go-oidc/blob/v2/.travis.yml#L4.

@mitar
Copy link
Copy Markdown
Contributor

mitar commented May 12, 2022

+1 for getting this in.

@mitar
Copy link
Copy Markdown
Contributor

mitar commented May 18, 2022

For anyone else going around this, you can currently do something like:

	provider, err := oidc.NewProvider(ctx, issuer)
	if err != nil {
		return nil, err
	}

	var claims struct {
		EndSessionURL string `json:"end_session_endpoint"`
	}
	err = provider.Claims(&claims)
	if err != nil {
		return nil, err
	}
	// ... claims.EndSessionURL is now end session URL to use

You have to construct final URL yourself, but it gets you moving.

@ABGEO
Copy link
Copy Markdown

ABGEO commented Jun 22, 2023

Hello,

Any updates on this?

@jschlechtengrok
Copy link
Copy Markdown

+1 This would be a welcome addition to the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants