Docker Deployment #17
Conversation
Dockerfile
Outdated
|
|
||
| ADD bin/issue-sync /opt/issue-sync/issue-sync | ||
|
|
||
| CMD ["./issue-sync"] No newline at end of file |
There was a problem hiding this comment.
Please use the ENTRYPOINT command rather than CMD. When using CMD with no entrypoint, docker implicitly uses an entrypoint of /bin/sh. This means that if you docker run quay.io/issue-sync <extra-args> docker will run /bin/sh -c '<extra-args>'; to get this to work you would have to docker run quay.io/issue-sync ./issue-sync <extra-args>. Instead, if you add /opt/issue-syncas the entrypoint, you candocker run quay.io/issue-sync ` and have them work as expected.
Dockerfile
Outdated
|
|
||
| WORKDIR /opt/issue-sync | ||
|
|
||
| ADD bin/issue-sync /opt/issue-sync/issue-sync |
There was a problem hiding this comment.
Use COPY rather than ADD. COPY is the recommended command and avoids some extra magic that ADD performs.
Dockerfile
Outdated
|
|
||
| ADD bin/issue-sync /opt/issue-sync/issue-sync | ||
|
|
||
| CMD ["./issue-sync"] No newline at end of file |
|
@squat Fixed. |
|
@LyonesGamer the PR is independent of the previos PRs. Let's rebase the commits off of master and merge this now |
The dockerfile copies over the issue-sync binary, and on a `docker run` runs the issue-sync binary.
2 participants
Depends on #16.
Add a Dockerfile to enable us to deploy the app.
@squat