Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

Conversation

@MorganEPatch
Copy link
Contributor

@MorganEPatch MorganEPatch commented Jul 14, 2017

Depends on #6.

Now that heavy work has been done on the tool, its usage needs to be documented.

@MorganEPatch MorganEPatch self-assigned this Jul 14, 2017
@MorganEPatch MorganEPatch mentioned this pull request Jul 17, 2017
README.md Outdated
# issue-sync
A tool for synchronizing issues between GitHub and JIRA

Issue-sync is an automated tool for synchronizing GitHub and JIRA issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it;s not an automated tool until you add actual automation. It is automatable. just say issue-sync is a tool for ...

README.md Outdated
## Usage

To use, first ensure you have a JIRA server with the project you want
to track on it - it can be a cloud account, or self-hosted. As well,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/As well/Also. it's a little funny

README.md Outdated

To use, first ensure you have a JIRA server with the project you want
to track on it - it can be a cloud account, or self-hosted. As well,
make sure you have a user account which can access the project and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a user account that can access...

that qualifies or refines a selection, while which describes it

README.md Outdated
create issues on it; it's recommended that you create an account
specifically for the issue-sync tool.

To the project, add the following custom fields: `GitHub ID`, `GitHub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify: Add the following custom fields to the project. Inverting the sentence and separating it into to clauses is extra confusing

README.md Outdated

To the project, add the following custom fields: `GitHub ID`, `GitHub
Number`, `GitHub Labels`, `GitHub Status`, `GitHub Reporter`, and `Last
Issue-Sync Update`. These fields are required, and the names must match
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary comma

README.md Outdated
fields, `Last Issue-Sync` update must be a date time field, and the
remainder must be text fields.

Arguments to the program may be passed on the command line, or in a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary comma

README.md Outdated
repo-name|string|"coreos/issue-sync"|true|null
jira-uri|string|"https://jira.example.com|true|null
jira-project|string|"SYNC"|true|null
since|string|"2017-07-01"|false|"1970-01-01"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these use ISO format now, right?

README.md Outdated
jira-project|string|"SYNC"|true|null
since|string|"2017-07-01"|false|"1970-01-01"

Note that the repo-name must include the owner and repo, that jira-uri
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quote the key names to show that they are special values and not English

README.md Outdated

Note that the repo-name must include the owner and repo, that jira-uri
is the base URI of the JIRA instance, that jira-project is the project's
Key, not its name, and that since is in the format "YYYY-MM-DD".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to ISO right?

README.md Outdated

After a successful run, the current configuration, with command line
arguments overwritten, is saved to the configuration file (either the
one provided, or `$HOME/.issue-sync.json"); the "since" date is updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the backtick quoting

Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. squash the README commits and this could be merged as soon as you like. if the functionality it describes depends on the previous PRs, then lets wait until those land.

The README likely needs some futher cleaning up and some
clarification, but this version at least explains how the tool
works and how to use it.
@MorganEPatch MorganEPatch merged commit 54a7214 into coreos:master Jul 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants