Skip to content

Add ci to generate examples in rhcos branch#20

Merged
cgwalters merged 1 commit intocoreos:mainfrom
jmarrero:ci-rhcos
May 15, 2022
Merged

Add ci to generate examples in rhcos branch#20
cgwalters merged 1 commit intocoreos:mainfrom
jmarrero:ci-rhcos

Conversation

@jmarrero
Copy link
Copy Markdown
Member

@jmarrero jmarrero commented May 13, 2022

Does initial generation of the rhcos branch by changing the FROM lines on any Dockerfiles found.

For this to work I think we need:

  • create rhcos branch based on the current main branch on this repository.
  • to add the https://github.com/coreosbot-releng token to the secrets in this repository.
  • fork this repository to github.com/coreosbot-releng/coreos-layering-examples

At least based on my tests with my forks that should make it work. But I don't have the credentials or access to do these things I believe.

Copy link
Copy Markdown
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me, one nit.

Comment thread ci/generate-rhcos-versions.py Outdated
Copy link
Copy Markdown
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert
Copy link
Copy Markdown
Contributor

There's an existing rhcos branch here, and I'm not sure of its status, so I'll let other folks in this repo handle that part. I've done the other two setup steps, and I agree that the three steps together should be sufficient. 👍

@cgwalters
Copy link
Copy Markdown
Member

There's an existing rhcos branch here, and I'm not sure of its status, so I'll let other folks in this repo handle that part.

I've pushed a copy of the current tip of rhcos as rhcos-orig for historical reference.

@cgwalters cgwalters merged commit 6e775ed into coreos:main May 15, 2022
@jmarrero
Copy link
Copy Markdown
Member Author

thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants