Add ci to generate examples in rhcos branch#20
Merged
cgwalters merged 1 commit intocoreos:mainfrom May 15, 2022
jmarrero:ci-rhcos
Merged
Add ci to generate examples in rhcos branch#20cgwalters merged 1 commit intocoreos:mainfrom jmarrero:ci-rhcos
cgwalters merged 1 commit intocoreos:mainfrom
jmarrero:ci-rhcos
Conversation
cgwalters
approved these changes
May 13, 2022
Member
cgwalters
left a comment
There was a problem hiding this comment.
Looks generally good to me, one nit.
cgwalters
approved these changes
May 13, 2022
Contributor
|
There's an existing |
Member
I've pushed a copy of the current tip of |
Member
Author
|
thank you both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does initial generation of the rhcos branch by changing the FROM lines on any Dockerfiles found.
For this to work I think we need:
At least based on my tests with my forks that should make it work. But I don't have the credentials or access to do these things I believe.