generate-rhcos-versions: Only inject ADD rhel.repo if needed#26
Merged
cgwalters merged 5 commits intocoreos:mainfrom Jun 9, 2022
Merged
generate-rhcos-versions: Only inject ADD rhel.repo if needed#26cgwalters merged 5 commits intocoreos:mainfrom
ADD rhel.repo if needed#26cgwalters merged 5 commits intocoreos:mainfrom
Conversation
`file` is a builtin Python keyword, we shouldn't override it.
It's more readable this way.
Only some of the examples actually install packages, not all. In particular the `selinux` one does not, and I want to use it as a test case to fix openshift/os#829 I'm thinking actually we should drop this bit entirely and rely on host subscriptions *or* users doing it on their own, but for now this works.
bgilbert
reviewed
Jun 8, 2022
bgilbert
approved these changes
Jun 8, 2022
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate-rhcos-versions: s/file/name/
fileis a builtin Python keyword, we shouldn't override it.generate-rhcos-versions: De-indent loop
It's more readable this way.
generate-rhcos-versions: Only inject
ADD rhel.repoif neededOnly some of the examples actually install packages, not all.
In particular the
selinuxone does not, and I want to use itas a test case to fix openshift/os#829
I'm thinking actually we should drop this bit entirely and rely
on host subscriptions or users doing it on their own, but
for now this works.