Skip to content

Conversation

@fzipi
Copy link
Member

@fzipi fzipi commented Sep 16, 2022

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

  • tags are based on build date using YYYYMMDDHHMM

This is the same as coreruleset/modsecurity-docker#140 for this repository.

Fixes #67.

@fzipi fzipi added the enhancement New feature or request label Sep 16, 2022
@fzipi
Copy link
Member Author

fzipi commented Sep 17, 2022

I'm delaying merging this so we can push a couple changes in the base container. Will use full version in the FROM directives in the build process now.

@fzipi fzipi changed the base branch from master to develop September 17, 2022 22:08
@fzipi fzipi force-pushed the change-docker-tagging branch 4 times, most recently from 7678396 to 944270c Compare September 17, 2022 22:21
@fzipi fzipi requested a review from theseion September 20, 2022 23:03
- tags are based on build date using YYYYMMDDHHMM

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Copy link
Contributor

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Max Leske <maxleske@gmail.com>
@fzipi fzipi merged commit a09c130 into develop Sep 22, 2022
@theseion theseion deleted the change-docker-tagging branch September 22, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Look on how to retain older images in case latest is broken

3 participants