Skip to content
This repository was archived by the owner on Nov 26, 2022. It is now read-only.

Conversation

@khiemdoan
Copy link
Contributor

No description provided.

@theseion
Copy link
Contributor

theseion commented Jun 6, 2022

This only adds PCRE2 support to YAJL, correct?

@khiemdoan
Copy link
Contributor Author

@theseion no, this adds PCRE2 to libmodsecurity follows the comment owasp-modsecurity/ModSecurity#2719 (comment),
you can try to see it already linked to pcre2:

ldd /usr/local/modsecurity/lib/libmodsecurity.so
    linux-vdso.so.1 (0x00007fff60dc6000)
    libcurl-gnutls.so.4 => /usr/lib/x86_64-linux-gnu/libcurl-gnutls.so.4 (0x00007fe2e8361000)
    libGeoIP.so.1 => /usr/lib/x86_64-linux-gnu/libGeoIP.so.1 (0x00007fe2e8323000)
    libxml2.so.2 => /usr/lib/x86_64-linux-gnu/libxml2.so.2 (0x00007fe2e8175000)
    liblua5.3.so.0 => /usr/lib/x86_64-linux-gnu/liblua5.3.so.0 (0x00007fe2e813b000)
    libpcre2-8.so.0 => /usr/lib/x86_64-linux-gnu/libpcre2-8.so.0 (0x00007fe2e80a3000)
    libfuzzy.so.2 => /usr/local/lib/libfuzzy.so.2 (0x00007fe2e809c000)
    ...

@fzipi
Copy link
Member

fzipi commented Jun 6, 2022

Nginx 1.21.x is not stable. And I don't know if we should go for 1.22.0 yet...

@theseion
Copy link
Contributor

theseion commented Jun 6, 2022

@khiemdoan ah yes, sorry.
We had a discussion on Slack about PCRE2 a couple of weeks back. I'm pretty sure that not everyone will want to switch to PCRE2, at least not immediately. So we might have to consider producing two variants for the two PCRE versions.

@khiemdoan
Copy link
Contributor Author

@theseion I agree with you that we should have two versions for testing and comparing.

@khiemdoan
Copy link
Contributor Author

@fzipi I have tested with nginx 1.22.0, it runs without any problem. Let me make a commit.

@fzipi
Copy link
Member

fzipi commented Jun 16, 2022

Thanks Kiem. We are aware that we still have this one, we need more time to think how are we going to tag them.

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this one instead of #131 .

@fzipi fzipi changed the title Support to PCRE2 feat(nginx): update to 1.22.0 with support for PCRE2 Aug 19, 2022
@fzipi fzipi merged commit d5b5389 into coreruleset:master Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants