This repository was archived by the owner on Nov 26, 2022. It is now read-only.
bugfix: clean up log formats #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Builds won't wont until we merge #140 I suspect. Or the fix, using |
Contributor
Author
|
I suspected that when I saw the message about |
fzipi
force-pushed
the
clean-log-formats
branch
from
70e42b9 to
55647b3
Compare
- The `perflogjson` format did not exist and the `PERFLOG` environment variable had no effect because `write_perflog` was never set. - Add comments about predefined log formats
fzipi
force-pushed
the
clean-log-formats
branch
from
55647b3 to
95c7613
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perflogjsonformat did not exist and thePERFLOGenvironment variable had no effect becausewrite_perflogwas never set.Fixes #128