bugfix: incorrect apply_patch for the move operation for the same list#31
Merged
corka149 merged 1 commit intocorka149:masterfrom Jul 19, 2025
Merged
bugfix: incorrect apply_patch for the move operation for the same list#31corka149 merged 1 commit intocorka149:masterfrom
corka149 merged 1 commit intocorka149:masterfrom
Conversation
corka149
requested changes
Jul 18, 2025
Owner
corka149
left a comment
There was a problem hiding this comment.
Please update expected error values in the tests. Else LGTM!
corka149
approved these changes
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the project, I noticed move operation is not correctly applied when both source and target are coming from the same list. Eg this test was failing.
Reason
We were first inserting and then removing. If it happened within the same list, remove operation might have targeted invalid object because indices are updated after insertion. It should first remove and then insert.
Solution
Now order of operations is correct: First, we determine which element should be inserted. Next, we remove that element, and as a last step we add previously remembered element into desired place.