Skip to content

Conversation

@ElliottAYoung
Copy link
Contributor

@ElliottAYoung ElliottAYoung commented Apr 21, 2017

Purpose:

Adds JS for required fields, making sense of what's being passed over from the plugin as of #56

As a writer, when I create a new blog from the dashboard, I automatically see the red field errors before I've even begun.

JIRA:

https://cb-content-enablement.atlassian.net/browse/COR-736

Steps to Take On Prod

  • Go to the form to create a new Employer Blog
  • See that there are no red fields on form load

Changes:

  • Changes to setup

    • Will need to bump cortex-plugins-core to the changes seen in #56
  • Architectural changes

    • N/A
  • Migrations

    • N/A
  • Library changes

  • Side effects

    • N/A

Screenshots

  • Before

screen shot 2017-04-21 at 10 57 35 am

  • After

screen shot 2017-04-21 at 10 57 06 am

QA Links:

http://web.cortex-6.development.c66.me/

How to Verify These Changes

  • Specific pages to visit

    • Create an Employer Blog
  • Steps to take

    • See there are no red fields
  • Responsive considerations

    • N/A

Relevant PRs/Dependencies:

#56

Additional Information

N/A

@toastercup
Copy link
Member

@ElliottAYoung will there be a server for this?

@ElliottAYoung
Copy link
Contributor Author

Putting it together as we speak

Copy link
Contributor

@MKwenhua MKwenhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should eventually create a main.js file to call all of these initialization functions

@ElliottAYoung ElliottAYoung force-pushed the topic/COR-736-Error-Messages-on-New-Fields branch from 5290b28 to a725760 Compare April 25, 2017 15:37
@ElliottAYoung ElliottAYoung force-pushed the topic/COR-736-Error-Messages-on-New-Fields branch from dae3748 to 0914696 Compare April 25, 2017 16:12
@ElliottAYoung ElliottAYoung merged commit cda8451 into develop Apr 25, 2017
@ElliottAYoung ElliottAYoung deleted the topic/COR-736-Error-Messages-on-New-Fields branch April 25, 2017 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants