Skip to content

Conversation

@mrfantasticwonders
Copy link

Purpose:

Some good feedback for Cortex's README.md to address some recent changes to Cortex and to add advice.

  • Changed $ rake secret to $ bundle rails secret
  • Added a new section, 'Troublelshooting' which addresses permissions issues and a solution to properly link node using homebrew for OS X users.

JIRA:

N/A

Steps to Take On Prod

N/A

Changes:

  • Changes to setup

    • N/A
  • Architectural changes

    • N/A
  • Migrations

    • N/A
  • Library changes

    • N/A
  • Side effects

    • N/A

Screenshots

  • Before
    N/A
  • After
    N/A

QA Links:

N/A

How to Verify These Changes

Relevant PRs/Dependencies:

N/A

Additional Information

N/A

README.md Outdated
For a rudimentary setup, these variables should be configured:

* Use `$ rake secret` to generate `APP_SECRET` and `DEVISE_SECRET`
* Use `$ bundle rails secret` to generate `APP_SECRET` and `DEVISE_SECRET`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should become bundle exec rails secret

README.md Outdated

* Use `$ rake secret` to generate `APP_SECRET` and `DEVISE_SECRET`
* Use `$ bundle rails secret` to generate `APP_SECRET` and `DEVISE_SECRET`
* To generate the two tokens for `APP_SECRET` and `DEVISE_SECRET`, simply run the above formula twice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest merging this line with the line above - I think it could read like:

  • Execute $ bundle exec rails secret twice to generate both an APP_SECRET and a DEVISE_SECRET

README.md Outdated

## Troubleshooting
* Ensure you have read / write access to your project directory during installation.
* Run `npm -v` to make sure node is properly linked. If the command is not found, chances are the correct version of node is not linked. Run `brew link node`.
Copy link
Member

@toastercup toastercup May 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a note that this is only relevant for OS X. Also, I'd suggest a more accurate way to check that node is linked is to run which node, and ensure its path matches Homebrew's default installation path

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely will add the note about OS X. I'm thinking adding your last point as a second point (the more accurate point) and the comment about running npm -v as a third point as another trick in finding out if node is linked correctly.

Running brew link node will also alert you of any folders / files on the computer (not related to version installed by homebrew) that might be conflicting with your install.

@mrfantasticwonders
Copy link
Author

mrfantasticwonders commented May 1, 2017

Current Tasks

  • Change bundle rails secret to bundle exec rails secret per @ElliottAYoung
  • Remove and merge line about running the secret formula twice to generate tokens per @toastercup
  • Reorg toubleshooting comments per @toastercup

…garding generating secret keys twice in environment section
@mrfantasticwonders
Copy link
Author

mrfantasticwonders commented May 1, 2017

@arelia to review.

@arelia
Copy link
Contributor

arelia commented May 1, 2017

@mrfantasticwonders et al, mind if I take till the end of the week to try these steps on my personal computer and then give feedback?

@toastercup toastercup dismissed ElliottAYoung’s stale review May 19, 2017 17:26

Change request has been addressed by David

@toastercup toastercup merged commit 0a1b047 into develop May 19, 2017
@toastercup toastercup deleted the topic/april-2017-readme-updates branch May 19, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants